[Drawkit] Notification for change in selection

[Graham Cox]

On 30/06/2009, at 8:42 AM, Brad Larson wrote:

> I'll try a list, and see how that goes.

Thanks Brad! Appreciate the effort... I've been through and addressed  
all of these. Some were already fixed, maybe about a quarter, but the  
rest were new on me, so thanks for finding them.

Where names have changed it's in line with convention, e.g.  
newQuartzPath and so forth. DK client code may need to be revised if  
you are calling these methods, though in most cases they are low-level  
and likely to be used internally only.

> GCOneShotEffectTimer
> In + (id)	oneShotWithTime:(NSTimeInterval) t forDelegate:(id) del
> it looks to be the same naming issue with returning retained objects.

This is about the only special case. The job of this class is to fade  
out a window (or perform any other thing that takes a little time), so  
it needs to stick around until the job is done, at which point it  
releases itself - effectively it is its own client. This is supposed  
to be transparent to code that creates this, so it's deliberately not  
named new[...] so that the caller isn't misled into thinking they need  
to release it. If they do, it will fail badly. I could double-retain  
it and rename it new[...] but the additional release is unnecessary  
and the analyzer may well complain about a retain of 2! I'll have to  
think about how this should be handled.

> Sorry about the long list.

Not at all - I'm relieved it's actually quite short.

cheers, Graham